Generate PDFs from Power Test Records #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickw29
previously approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Looks good thanks @jb3 , I think maybe there's a bit of discussion to be had about what else we think would be useful to show and refine the content as we probably also want stuff like event size on there but it's an excellent starting point
|
Thanks for the review. Will address lint failures shortly. |
nickw29
approved these changes
Oct 14, 2024
|
CI issues now seem to be that the CI builder is trying to setup 3.9 whilst the Pipfile mandates 3.10, I can look at this in another PR but the linting issues are passing locally. |
|
Ugh the CI and tests have been broken for a while. If you have the time and energy to look at it that would be awesome 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Allows for the export of PDFs, similar to how Risk Assessments can be exported, but for power test records from events.
This generates a two page document, the first page comprising of high level event detail such as:
The second page contains all the inputted values from the power test plan in a format similar to the HTML version.
Review status of the results is reflected on the first page, the table containing worst points scales depending on how many are inputted/stored.
Future Improvements
Speaking with Nick today in future it might be nice to expand power test records more with:
Miscellaneous
This PR also fixes the fact that exported PDFs never had a total number of pages, it would always say something like "Page 2 of 0", adding a
<namedString>fixes this, we previously had a reference to this namedString but it didn't exist so the default of0was used.